Save advertisements as CAR files #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 54.31% // Head: 54.35% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #1210 +/- ##
==========================================
+ Coverage 54.31% 54.35% +0.03%
==========================================
Files 151 154 +3
Lines 15028 15606 +578
==========================================
+ Hits 8163 8482 +319
- Misses 5964 6162 +198
- Partials 901 962 +61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gammazero
commented
Feb 1, 2023
masih
approved these changes
Feb 7, 2023
When configured to save advertisements, save advertisements and entries from the datastore as CAR files in the configured directory. The advertisement and its entries are removed from the datastore after they are saved as a CAR file. If there are existing advertisements saved in the datastore, on startup, save these as CAR files and remove them from the datastore. Advertisements are not saved when the indexer is frozen.
…ies CAR - The CarWriter uses a filestore.Interface to seemlessly support different file store implementations (local filesystem, S3, etc.). - Separate advertisements and entries into separate CAR files. This allows loading advertisements withing having to load the links, and is useful when an loading ad advertisement whose entries have already been deleted.
- Remove _adv and _mhs file suffixes. - Add option to overwrite S3 endpoint.
gammazero
force-pushed
the
save-ad-as-car
branch
from
1688af0
to
40ca848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configured to save advertisements, save advertisements and entries from the datastore as CAR files in the configured directory. The advertisement and its entries are removed from the datastore after they are saved as a CAR file.
If there are existing advertisements saved in the datastore, on startup, save these as CAR files and remove them from the datastore.
Advertisements are not saved when the indexer is frozen.