Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ber and cali indexers #1888

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Remove ber and cali indexers #1888

merged 1 commit into from
Jul 7, 2023

Conversation

gammazero
Copy link
Collaborator

@gammazero gammazero commented Jun 5, 2023

Remove the unencrypted indexers ber and cali. These are no longer needed as the encrypted dhstore and dhstore+FDB are sufficiently populated for dhfind to retrieve unencrypted data from them.

@gammazero gammazero requested a review from masih June 5, 2023 18:55
Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good; the only issue is dev web UI which I think would break. I think if we use ago as fallback it would work? not sure.

@gammazero gammazero requested a review from masih June 6, 2023 14:41
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.12 🎉

Comparison is base (d68d457) 47.75% compared to head (4daad50) 47.88%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1888      +/-   ##
==========================================
+ Coverage   47.75%   47.88%   +0.12%     
==========================================
  Files          95       95              
  Lines       10250    10250              
==========================================
+ Hits         4895     4908      +13     
+ Misses       4782     4771      -11     
+ Partials      573      571       -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gammazero gammazero merged commit 3e4d9e1 into main Jul 7, 2023
15 of 16 checks passed
@gammazero gammazero deleted the remove-ber-and-cali branch July 7, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants