Reduce compaction thresholds back on qui
#2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After experimentation, it seems parallelism of 20 on the current node type that qiu is running on yields fast enough compaction debt catch up at the rate of ~40GiB per hour. Reducing compaction thresholds back down to keep compaction as aggressive as before. We may need to reduce these further depending on write load. For now the limits seem to result in a stable read amplification (on helga) which uses the same thresholds as default values.
gammazero
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After experimentation, it seems parallelism of 20 on the current node type that qiu is running on yields fast enough compaction debt catch up at the rate of ~40GiB per hour.
Reducing compaction thresholds back down to keep compaction as aggressive as before. We may need to reduce these further depending on write load. For now the limits seem to result in a stable read amplification (on helga) which uses the same thresholds as default values.