Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing deployment config for telemetry #2170

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Conversation

gammazero
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.26% 🎉

Comparison is base (f8639a4) 46.87% compared to head (64cc15c) 47.13%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2170      +/-   ##
==========================================
+ Coverage   46.87%   47.13%   +0.26%     
==========================================
  Files          90       90              
  Lines        9986     9986              
==========================================
+ Hits         4681     4707      +26     
+ Misses       4767     4740      -27     
- Partials      538      539       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some issues in the telemetry dev overlay which I can't comment on in this PR since that code is already merged. Here is the list:

  • No need to specify port here as it is already specified in base.
  • This will fail the deployment. It is not needed since telemetry has no identity nor config, nor the manifest specify such volumes to then be mounted.
  • 3 CPUs seems a tad too high?
  • There is no service-external. This line should be removed.

@gammazero gammazero merged commit b4264cc into main Jul 27, 2023
16 checks passed
@gammazero gammazero deleted the base-telemetry-config branch July 27, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants