Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not persist bootstrap peers #2187

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Do not persist bootstrap peers #2187

merged 2 commits into from
Aug 1, 2023

Conversation

gammazero
Copy link
Collaborator

There is no need for the indexer to persist bootstrap peers. Doing so may lead to unexpected behavior if the indexer connects to peers that it is no longer configured to connect to.

There is no need for the indexer to persist bootstrap peers. Doing so may lead to unexpected behavior if the indexer connects to peers that it is no longer configured to connect to.
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.13% 🎉

Comparison is base (020f9f8) 46.90% compared to head (70037cf) 47.04%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2187      +/-   ##
==========================================
+ Coverage   46.90%   47.04%   +0.13%     
==========================================
  Files          90       90              
  Lines        9986     9951      -35     
==========================================
- Hits         4684     4681       -3     
+ Misses       4765     4732      -33     
- Partials      537      538       +1     
Files Changed Coverage Δ
command/daemon.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero merged commit b0147df into main Aug 1, 2023
15 of 16 checks passed
@gammazero gammazero deleted the no-persist-bootstrap-peers branch August 1, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants