Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of go-libipni #2197

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Update to latest version of go-libipni #2197

merged 1 commit into from
Aug 2, 2023

Conversation

gammazero
Copy link
Collaborator

Context

Need to update go-libipni because it contains a fix for a graphsync deadlock

Proposed Changes

  • Includes fix for graphsync deadlock
  • Tests close libp2p hosts

Tests

No new tests needed

Revert Strategy

Change is safe to revert.

- Includes fix for graphsync deadlock
- Tests close libp2p hosts
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.10% 🎉

Comparison is base (73b7e28) 47.18% compared to head (c675361) 47.29%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2197      +/-   ##
==========================================
+ Coverage   47.18%   47.29%   +0.10%     
==========================================
  Files          90       90              
  Lines        9959     9964       +5     
==========================================
+ Hits         4699     4712      +13     
+ Misses       4719     4713       -6     
+ Partials      541      539       -2     
Files Changed Coverage Δ
assigner/command/daemon.go 0.00% <0.00%> (ø)
command/daemon.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero merged commit c201492 into main Aug 2, 2023
15 of 16 checks passed
@gammazero gammazero deleted the update-go-libipni branch August 2, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants