ADD: pass options to game state's setup() method #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaws.start() and jaws.switchGameState() now accept a third parameter which is passed to game state's setup() method
|
I can seenhow this is usable but i dont get the variablename..it has nothing to do with game objects? I also need to test a small thning before merging. |
|
Maybe "game_state_setup_options" would be better, as in "options for setup() in a given game state". |
|
indeed, could you rename it? afaik this doesn't break any old code since function foo() { .. }; foo(new_arguments); work just fine. |
|
Sorry for my late response, I was sick (still am) trough the weekend. I've renamed the variable now. |
ippa
pushed a commit
that referenced
this pull request
Jan 30, 2012
ADD: pass options to game state's setup() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jaws.start() and jaws.switchGameState() now accept a third parameter which is passed to game state's setup() method