Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return account details (remainingCredit, rateLimitRemaining etc) with… #4

Merged
merged 1 commit into from
Mar 12, 2020
Merged

return account details (remainingCredit, rateLimitRemaining etc) with… #4

merged 1 commit into from
Mar 12, 2020

Conversation

baxford
Copy link

@baxford baxford commented Mar 12, 2020

… lookup response

@baxford baxford mentioned this pull request Mar 12, 2020
Closed
@lpellegr lpellegr self-requested a review March 12, 2020 09:34
@lpellegr lpellegr added the enhancement New feature or request label Mar 12, 2020
@lpellegr lpellegr linked an issue Mar 12, 2020 that may be closed by this pull request
Return Remaining Credit and Rate Limit from http response headers #3
Closed
@lpellegr
Copy link
Collaborator

Thanks for this PR.

There are some changes we need to apply to keep responses and naming consistent for all client methods and client libraries. I will add some commits in this PR if it supports collaboration. Otherwise, I will merge it and extend your work directly on the master branch.

@lpellegr lpellegr merged commit b5b73ff into ipregistry:master Mar 12, 2020
lpellegr
lpellegr reviewed Mar 12, 2020
View reviewed changes
Copy link
Collaborator

@lpellegr lpellegr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging and extending directly in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpellegr lpellegr lpellegr left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return Remaining Credit and Rate Limit from http response headers
2 participants
@baxford @lpellegr