Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an explicit feature flag for IS-IS multi-topology support #1171

Closed

Conversation

jbemmel
Copy link
Collaborator

@jbemmel jbemmel commented May 10, 2024

And don't require it for ipv6-only scenarios

SR Linux removed support for IS-IS multi-topology in 23.10, but can still support ipv6-only deployments

Fixes #1169

@ipspace
Copy link
Owner

ipspace commented May 10, 2024

No.

You're adding a feature flag and modifying 5 device definitions (missing at least two others) just because you have a problem with a single device. Solve it with a device quirk.

Also, saying "we'll use multi-topology only in dual-stack deployments" doesn't help. What if part of the network is dual-stack and part of it is IPv6-only?

Finally, you fixed FRR template (because you care about that), but not all the others that also configure multi-topology. That's not how things work.

If you care about running IPv6 with IS-IS on SR Linux, please create a plugin that would implement all the IS-IS deployment scenarios you'd like to see, and add configuration templates for whichever devices you think should be supported by that plugin.

@ipspace ipspace closed this May 10, 2024
@jbemmel jbemmel deleted the isis-multi-topology-feature-flag branch May 10, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] isis/02-ipv6.yml validation fails due to FRR requiring multi-topology
2 participants