-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beautiful vxlan vrf evpn test/show case #458
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that we already have 'evpn' directory in 'tests/integration', I'd suggest you move this one there -- it's more about EVPN than VXLAN. |
Beautiful and powerful example (IMHO)
Note that FRR still works in that case, though technically it shouldn't
Rename groups
65b8848
to
b341be4
Compare
ipspace
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope you're done with this one -- you keep adding stuff even after marking the PR 'ready for review'
Merged
ipspace
pushed a commit
that referenced
this pull request
Oct 1, 2022
Co-authored-by: Jeroen van Bemmel <jeroen.van_bemmel@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
85 lines of YAML to magically create a sophisticated topology using open source components
For those who frown upon iBGP-over-eBGP designs, I added hints on what to change to use OSPF or ISIS instead of eBGP
Note: I also cleaned up the iBGP-over-eBGP example that was already there, simplifying the modules on the spine