Skip to content

Commit

Permalink
Removed old code
Browse files Browse the repository at this point in the history
  • Loading branch information
akadlec committed May 23, 2021
1 parent 1fa0589 commit deb0d98
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 32 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@ This extension adds support for dynamic definition of [Doctrine](http://www.doct

## Installation

The best way to install ipub/doctrine-dynamic-discriminator-map is using [Composer](http://getcomposer.org/):
The best way to install **ipub/doctrine-dynamic-discriminator-map** is using [Composer](http://getcomposer.org/):

```sh
$ composer require ipub/doctrine-dynamic-discriminator-map
composer require ipub/doctrine-dynamic-discriminator-map
```

After that you have to register extension in config.neon.

```neon
extensions:
dynamicDiscriminatorMap: IPub\DoctrineDynamicDiscriminatorMap\DI\DoctrineDynamicDiscriminatorMapExtension
dynamicDiscriminatorMap: IPub\DoctrineDynamicDiscriminatorMap\DI\DoctrineDynamicDiscriminatorMapExtension
```

## Documentation
Expand Down
4 changes: 2 additions & 2 deletions docs/en/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ This extension adds support for dynamic definition of [Doctrine](http://www.doct

## Installation

The best way to install ipub/doctrine-dynamic-discriminator-map is using [Composer](http://getcomposer.org/):
The best way to install **ipub/doctrine-dynamic-discriminator-map** is using [Composer](http://getcomposer.org/):

```sh
$ composer require ipub/doctrine-dynamic-discriminator-map
composer require ipub/doctrine-dynamic-discriminator-map
```

After that you have to register extension in config.neon.
Expand Down
3 changes: 0 additions & 3 deletions phpstan.neon
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
parameters:
level: max
stubFiles:
- tests/PHPStan/stubs/Doctrine/ORM/Query.php
- tests/PHPStan/stubs/Doctrine/ORM/QueryBuilder.php
14 changes: 6 additions & 8 deletions src/Events/DynamicDiscriminatorSubscriber.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@
* @subpackage Events
*
* @author Adam Kadlec <adam.kadlec@ipublikuj.eu>
*
* @template TEntityClass of object
*/
final class DynamicDiscriminatorSubscriber implements Common\EventSubscriber
{
Expand Down Expand Up @@ -64,7 +62,7 @@ public function getSubscribedEvents(): array
public function loadClassMetadata(ORM\Event\LoadClassMetadataEventArgs $eventArgs): void
{
$metadata = $eventArgs->getClassMetadata();
/** @phpstan-var ReflectionClass<TEntityClass> $classReflection */
/** @phpstan-var ReflectionClass<object> $classReflection */
$classReflection = $metadata->getReflectionClass();

$reader = new Common\Annotations\AnnotationReader();
Expand Down Expand Up @@ -104,7 +102,7 @@ public function loadClassMetadata(ORM\Event\LoadClassMetadataEventArgs $eventArg
* @throws Exceptions\InvalidStateException
* @throws ReflectionException
*
* @phpstan-param ReflectionClass<TEntityClass> $parentClassReflection
* @phpstan-param ReflectionClass<object> $parentClassReflection
*/
private function detectFromChildren(ORM\EntityManager $em, ReflectionClass $parentClassReflection): array
{
Expand All @@ -116,9 +114,9 @@ private function detectFromChildren(ORM\EntityManager $em, ReflectionClass $pare
throw new Exceptions\InvalidStateException('Entity manager mapping driver could not be loaded');
}

/** @phpstan-var class-string of object $class */
/** @phpstan-var class-string $class */
foreach ($mappingDriver->getAllClassNames() as $class) {
/** @phpstan-var ReflectionClass<TEntityClass> $childrenClassReflection */
/** @phpstan-var ReflectionClass<object> $childrenClassReflection */
$childrenClassReflection = new ReflectionClass($class);

if ($childrenClassReflection->getParentClass() === false) {
Expand Down Expand Up @@ -146,7 +144,7 @@ private function detectFromChildren(ORM\EntityManager $em, ReflectionClass $pare
*
* @throws ReflectionException
*
* @phpstan-param ReflectionClass<TEntityClass> $classReflection
* @phpstan-param ReflectionClass<object> $classReflection
*/
private function getDiscriminatorForClass(ReflectionClass $classReflection): ?string
{
Expand Down Expand Up @@ -177,7 +175,7 @@ private function getDiscriminatorForClass(ReflectionClass $classReflection): ?st
*
* @throws Exceptions\DuplicatedDiscriminatorException
*
* @phpstan-param ReflectionClass<TEntityClass> $classReflection
* @phpstan-param ReflectionClass<object> $classReflection
*/
private function ensureDiscriminatorIsUnique(string $discriminator, ReflectionClass $classReflection): void
{
Expand Down
8 changes: 0 additions & 8 deletions tests/PHPStan/stubs/Doctrine/ORM/Query.php

This file was deleted.

8 changes: 0 additions & 8 deletions tests/PHPStan/stubs/Doctrine/ORM/QueryBuilder.php

This file was deleted.

0 comments on commit deb0d98

Please sign in to comment.