Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IPUCH PRIORITY] Fung et al. 2001 inconsistency #49

Closed
2 tasks done
Ipuch opened this issue Jul 10, 2023 · 4 comments
Closed
2 tasks done

[IPUCH PRIORITY] Fung et al. 2001 inconsistency #49

Ipuch opened this issue Jul 10, 2023 · 4 comments
Assignees
Labels
bug Something isn't working data_prep Preparation of the data to be used, afterwards

Comments

@Ipuch
Copy link
Owner

Ipuch commented Jul 10, 2023

row_data.joint Fung et al. 2001
Joint scapulothoracic has no correction value in the parent segment thorax, it should be filled with a Correction.TO_ISB_LIKE_ROTATION correction because the segment is not isb. Current value: []
Joint scapulothoracic has no correction value in the parent segment thorax, it should be filled with a Correction.TO_ISB_LIKE_ROTATION correction because the segment is not isb. Current value: []

I require a to_isb_like in the column correction, and correctable is true.

  • update sharepoint
  • update .csv file
@Ipuch Ipuch added the bug Something isn't working label Jul 10, 2023
@Ipuch Ipuch added the data_prep Preparation of the data to be used, afterwards label Jul 10, 2023
@ANaaim
Copy link
Collaborator

ANaaim commented Jul 18, 2023

The modification have been done in the file but when i try to update on the git updating the file only data_set_raw the modification have already been done.

@Ipuch Ipuch self-assigned this Oct 18, 2023
@Ipuch Ipuch changed the title Fung et al. 2001 inconsistency [IPUCH PRIORITY] Fung et al. 2001 inconsistency Oct 18, 2023
@Ipuch
Copy link
Owner Author

Ipuch commented Oct 22, 2023

image

@Ipuch
Copy link
Owner Author

Ipuch commented Oct 22, 2023

Do we put a Kolz correction for the scapula GC to AC, even if it's a glenoid centered frame, instead of a ISB-like glenoid centered as defined in Kolz et al.

@Ipuch Ipuch mentioned this issue Apr 22, 2024
@Ipuch
Copy link
Owner Author

Ipuch commented May 31, 2024

Done. no correction at the moment.

@Ipuch Ipuch closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data_prep Preparation of the data to be used, afterwards
Projects
None yet
Development

No branches or pull requests

2 participants