Use browseURL() and require rstudioapi in ipums_view() (#62)

Co-authored-by: Derek Burk <burkx031@umn.edu>
ipums · Oct 17, 2023 · c7a7ec0 · c7a7ec0
1 parent dcd298b
commit c7a7ec0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/R/viewer.R b/R/viewer.R
@@ -61,10 +61,13 @@ ipums_view <- function(x, out_file = NULL, launch = TRUE) {
   htmltools::save_html(html_page, out_file)
 
   if (launch) {
-    if (requireNamespace("rstudioapi", quietly = TRUE)) {
+    if (requireNamespace("rstudioapi", quietly = TRUE) && rstudioapi::isAvailable()) {
       rstudioapi::viewer(out_file)
     } else {
-      shell.exec(out_file)
+      rlang::abort(c(
+        "RStudio and the rstudioapi package are required to use `ipums_view()`",
+        "i" = "Install rstudioapi with `install.packages(\"rstudioapi\")`"
+      ))
     }
     invisible(out_file)
   } else {

diff --git a/R/web_url.R b/R/web_url.R
@@ -122,7 +122,7 @@ ipums_website.ipums_ddi <- function(x,
   )
 
   if (launch) {
-    system2("open", url)
+    utils::browseURL(url)
     invisible(url)
   } else {
     url
@@ -180,7 +180,7 @@ ipums_website.character <- function(x,
   )
 
   if (launch) {
-    system2("open", url)
+    utils::browseURL(url)
     invisible(url)
   } else {
     url