meson.build: fix static build with gcrypt #185
Conversation
|
I'll update the PR shortly to fix build failure |
|
I didn't test it when gcrypt was disabled :-/ |
gcrypt depends on gpg-error so save the result of
dependency('gpg-error') in gpg_error_dep and use it when needed to fix
static build
Fixes:
- http://autobuild.buildroot.net/results/fb698e3e903869978bd5e69d791ec362317b7981
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
|
I think first version was close what is needed, but without new variable. If I understood the issue correctly gcrypt, and gcrypt only, will require gpg-error. Linking with it in other cases would pull in unnecessary library reference when not needed. So how about changing crypto_dep variable to be array that can hold multiple dependencies, and requiring two when that's the case and one at rest of the time. See below how I think that could be done. BTW it would great to hear if that version will fix all known issues, so please give a try if possible. |
|
I tested your version, it fixes the buildroot's build failure and is indeed a better solution than my proposal. |
|
Great to hear @ffontaine, eabe211 is merged. |
gcrypt depends on gpg-error so save the result of
cc.find_library('gpg-error') in gpg_error_dep and use it when needed to
fix static build
Fixes:
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com