tracepath: identify interfaces when available #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishaangandhi
force-pushed
the
traceroute-pr
branch
from
4bc9724
to
c93b1ef
Compare
nmeyerhans
reviewed
Apr 17, 2021
| if (ipaddr_flag) { | ||
| if (offset + 8 > pkt_len || ntohs(*(uint16_t *)(pkt + offset)) != 1) | ||
| goto err; | ||
| printf(" address=%s;", inet_ntop(AF_INET, &pkt[offset + 4], if_addr, sizeof(if_addr))); |
There was a problem hiding this comment.
Any reason why you're not handling AF_INET6?
There was a problem hiding this comment.
Only called setsockopt with IP_RECVERR_RFC4884 not the IPv6 equivalent, so any interface returned in a well-formed packet will be IPv4.
Why not setsockopt with IPV6_RECVERR_RFC4884? I haven't had time to test it yet. It will be a relatively painless patch once I can test it.
|
(For testing: this patch can be applied to Linux 5.9+) |
RFC 5837 extends ICMP to provide more information about the interfaces packets move through as they flow through the network. This patch prints those extensions when available. Signed-off-by: Ishaan Gandhi<ishaangandhi@gmail.com>
ishaangandhi
force-pushed
the
traceroute-pr
branch
from
c93b1ef
to
9f09f30
Compare
|
For a record kernel part still have not been merged: https://lore.kernel.org/netdev/?q=Ishaan+Gandhi+5837 |
pevik
added
enhancement
requires-kernel-patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 5837 extends ICMP to provide more information about the interfaces packets move through as they flow through the network.
This patch prints those extensions when available.
Signed-off-by: Ishaan Gandhi ishaangandhi@gmail.com