Ping: Remove binding of ICMP socket #341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When specifying an interface in the ping command, if trying to ping an address that is not reachable then no errors would be received. This was because the ICMP socket was being bound to the source interface but the errors were coming through the loopback interface. To fix this the ICMP socket should not be bound to the interface. Instead IPv4 ping should copy IPv6's use of cmsg. A cmsg header will contain information about the interface and will then be included in the msg header when sending a ping. This means the outgoing ping uses the correct interface but incoming messages from other interfaces can still be received on the socket.
|
This commit would fix #339 |
As the ICMP socket is no longer being bound to the interface, it will never need to be unbound.
|
This commit don't even compile. |
|
@tashanamatl Does the problem still exists in the latest release and in the current master? If yes, how to reproduce it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying an interface in the ping command, if trying to ping an
address that is not reachable then no errors would be received. This was
because the ICMP socket was being bound to the source interface but the
errors were coming through the loopback interface.
To fix this the ICMP socket should not be bound to the interface.
Instead IPv4 ping should copy IPv6's use of cmsg. A cmsg header will
contain information about the interface and will then be included in the
msg header when sending a ping. This means the outgoing ping uses the
correct interface but incoming messages from other interfaces can still
be received on the socket.