ping: read from error queue when POLLERR is set #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon POLLERR, ping reads from the socket and, unless there is an errno other than EAGAIN or EINTR, it will not read the error queue. However, due to races on sk->sk_err, it is more robust to always read the error queue when the socket read retruns an EAGAIN and poll returns POLLERR. Tested-by: Cyril Hrubis <chrubis@suse.cz> Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon POLLERR, ping reads from the socket and, unless there is
an errno other than EAGAIN or EINTR, it will not read the error
queue.
However, due to races on sk->sk_err, it is more robust to
always read the error queue when the socket read retruns
an EAGAIN and poll returns POLLERR.
Fixes #74