refactor: first-pass at runtime interface, signals, shutdown, and more #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanlakhani
force-pushed
the
zl/cli+shutdown-start
branch
from
2a2da51
to
18cde9e
Compare
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
==========================================
+ Coverage 47.97% 51.42% +3.45%
==========================================
Files 50 56 +6
Lines 2193 2349 +156
Branches 539 571 +32
==========================================
+ Hits 1052 1208 +156
+ Misses 817 773 -44
- Partials 324 368 +44
|
1 task
zeeshanlakhani
force-pushed
the
zl/cli+shutdown-start
branch
from
d39ae60
to
a6d3157
Compare
This work precedes subsequent work on running workflows from the Homestar runner/server/runtime but sets everything into gear. Includes: * overall refactoring of events and event handling, streamlining how to work with senders, etc * introduce a runner which can - interact with task/batch specific-abort handles introduced in joinsets within a worker - interact with commands, which will happen through the CLI interface, i.e. star, run-workflow, akin to something like temporal-server - start-up event handler, websocket server, takes in db and can mock via implementation * lots of cleanups
zeeshanlakhani
force-pushed
the
zl/cli+shutdown-start
branch
from
a6d3157
to
482b0a8
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work precedes subsequent work on running workflows from the Homestar runner/server/runtime but sets everything into gear.
Includes: