Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner + RPC #203

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Runner + RPC #203

merged 4 commits into from
Jul 21, 2023

Conversation

zeeshanlakhani
Copy link
Contributor

Includes:

  • restructure main
  • separate logger interface for rolling files vs stdout (all async nonblocking)
  • tarpc (non-proto) Server/Client implementation to "speak" RPC to the Runner
  • db initialization cleanup
  • Lots of channel scaffolding and reliance
  • CLI output with tables and diagnostic error(s)
  • Make resolve take an async closure and work via async_recursion
  • ability to run homestar runner/server in daemon mode
  • docker cleanup and now having an entrypoint w/ homestar start
  • cargo-nextest configuration
  • CLI / e2e RPC tests in serial mode
  • build.rs for compile-time pending migrations (if not run previously)
  • handle ports correctly for parallel tests
  • prep for worker set and delayqueue
  • ARCify your demons
  • proper use of spawn and block_on within a Runner's (tokio) runtime
  • rwlock for linkmap (cross-thread)

@zeeshanlakhani zeeshanlakhani requested a review from a team as a code owner July 21, 2023 03:35
Includes:

* restructure main
* separate logger interface for rolling files vs stdout (all async nonblocking)
* tarpc (non-proto) Server/Client implementation to "speak" RPC to the Runner
* db initialization cleanup
* Lots of channel scaffolding and reliance
* CLI output with tables and diagnostic error(s)
* Make resolve take an async closure and work via async_recursion
* ability run homestar runner/server in daemon mode
* docker cleanup and now having an entrypoint w/ homestar start
* cargo-nextest configuration
* CLI / e2e RPC tests in serial mode
* build.rs for compile-time pending migrations (if not run previously)
* handle ports correctly for parallel tests
* prep for worker set and delayqueue
* ARCify your demons
* proper use of spawn and block_on within a Runner's (tokio) runtime
* rwlock for linkmap (cross-thread)
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #203 (b931d2a) into main (d8aa18f) will increase coverage by 29.38%.
The diff coverage is 80.17%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #203       +/-   ##
===========================================
+ Coverage   47.48%   76.86%   +29.38%     
===========================================
  Files          54       57        +3     
  Lines        2487     6057     +3570     
  Branches      608        0      -608     
===========================================
+ Hits         1181     4656     +3475     
- Misses        927     1401      +474     
+ Partials      379        0      -379     
Impacted Files Coverage Δ
homestar-runtime/src/event_handler.rs 100.00% <ø> (+26.08%) ⬆️
homestar-runtime/src/event_handler/swarm_event.rs 23.65% <0.00%> (+16.95%) ⬆️
homestar-runtime/src/cli/error.rs 11.11% <11.11%> (ø)
homestar-runtime/src/event_handler/event.rs 15.81% <25.00%> (+6.72%) ⬆️
homestar-core/src/workflow/input.rs 70.52% <29.62%> (+19.48%) ⬆️
homestar-runtime/src/event_handler/channel.rs 44.44% <50.00%> (-5.56%) ⬇️
homestar-runtime/src/event_handler/error.rs 57.14% <50.00%> (+7.14%) ⬆️
homestar-runtime/src/scheduler.rs 88.23% <50.00%> (+35.53%) ⬆️
homestar-runtime/src/cli.rs 68.08% <66.66%> (ø)
homestar-runtime/src/network/ws.rs 47.28% <72.72%> (+10.50%) ⬆️
... and 10 more

... and 41 files with indirect coverage changes

@zeeshanlakhani zeeshanlakhani merged commit 312a7af into main Jul 21, 2023
12 checks passed
@zeeshanlakhani zeeshanlakhani deleted the zl/runner-runtime branch July 21, 2023 07:55
@zeeshanlakhani zeeshanlakhani restored the zl/runner-runtime branch August 3, 2023 17:26
@zeeshanlakhani zeeshanlakhani deleted the zl/runner-runtime branch August 3, 2023 17:27
@release-plz-ipvm-wg release-plz-ipvm-wg bot mentioned this pull request Oct 9, 2023
This was referenced Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant