Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add release-plz schema action run #594

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Conversation

bgins
Copy link
Contributor

@bgins bgins commented Feb 29, 2024

Description

This PR makes the following changes:

  • Update schemas action to run on release-plz branches on manifest changes only
  • Update schemas action to run on main for both manifest and Rust changes

release-plz updates versions that we reference in schemas, which put the versions in the schemas out of date. This PR updates the action to handle version changes.

Type of change

  • Refactor (non-breaking change that updates existing functionality)

@bgins bgins force-pushed the bgins/run-schemas-release-plz branch 4 times, most recently from f7b73ea to e9f4559 Compare March 1, 2024 00:41
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.40%. Comparing base (2d77b0a) to head (9faac07).
Report is 8 commits behind head on main.

❗ Current head 9faac07 differs from pull request most recent head eaab37e. Consider uploading reports for the commit eaab37e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
- Coverage   72.42%   72.40%   -0.02%     
==========================================
  Files          95       95              
  Lines       12473    12505      +32     
==========================================
+ Hits         9033     9054      +21     
- Misses       3440     3451      +11     

see 3 files with indirect coverage changes

@bgins bgins force-pushed the bgins/run-schemas-release-plz branch from 9faac07 to 8d73246 Compare March 1, 2024 00:59
@bgins bgins marked this pull request as ready for review March 1, 2024 00:59
@bgins bgins requested a review from a team as a code owner March 1, 2024 00:59
@bgins bgins force-pushed the bgins/run-schemas-release-plz branch 12 times, most recently from 86ef6fb to 6cc8a64 Compare March 5, 2024 01:01
@bgins bgins force-pushed the bgins/run-schemas-release-plz branch from 7fb2081 to a21a9a5 Compare March 5, 2024 01:11
@bgins bgins force-pushed the bgins/run-schemas-release-plz branch from 1181d27 to eaab37e Compare March 5, 2024 01:39
@bgins bgins merged commit d0f969e into main Mar 5, 2024
13 checks passed
@bgins bgins deleted the bgins/run-schemas-release-plz branch March 5, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants