Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[efi] Add options to set console to native monitor resolution #47

Closed
wants to merge 1 commit into from

Conversation

jdieter
Copy link

@jdieter jdieter commented Mar 12, 2016

Currently, there's no way to change the screen mode to the optimum mode for the monitor. This patch adds two options to rectify that. The first option, '-a' or '--auto', chooses the first EFI graphics mode, which on most systems is the native mode.

However, on some systems the first mode is the mode the BIOS interface is designed to use, and may not actually be the native resolution of the monitor (i.e. the monitor resolution is 1600x900, while the first mode is 1280x1024). So the second option, '-w' or '--max-width', chooses the widest EFI graphics mode, on the assumption that that is the native monitor resolution.

In this patch, -w takes precedence over -a and both override the sizes given by -x, -y and -p.

Signed-off-by: Jonathan Dieter <jdieter@lesbg.com>
@ipxe-devel
Copy link

On 12/03/16 20:48, Jonathan Dieter wrote:

Currently, there's no way to change the screen mode to the optimum mode
for the monitor. This patch adds two options to rectify that. The first
option, '-a' or '--auto', chooses the first EFI graphics mode, which on
most systems is the native mode.

However, on some systems the first mode is the mode the BIOS interface
is designed to use, and may not actually be the native resolution of the
monitor (i.e. the monitor resolution is 1600x900, while the first mode
is 1280x1024). So the second option, '-w' or '--max-width', chooses the
widest EFI graphics mode, on the assumption that that is the native
monitor resolution.

Both of those seem like very crude heuristics which are likely to be
true only for certain systems and only when certain monitors are attached.

Can you find a better approach?

Michael

@jdieter
Copy link
Author

jdieter commented Mar 12, 2016

Yeah, just did some research and apparently we can get the EDID using EFI. I'm thinking that might be slightly more robust. It's getting late, so I'll look into that tomorrow.

@jdieter jdieter closed this Mar 12, 2016
@jdieter
Copy link
Author

jdieter commented Mar 12, 2016

And, yes, I do feel a bit like an idiot. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants