[digest] add sha1verify command #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to get a trusted image with known digest value that is embedded in the ipxe script making http downloads safe to use this way example usage: kernel http://boot.ipxe.org/memtest.0 sha1verify memtest.0 5d78d4c7e97c99bca3d3dff602b84dde5b70c5bf boot an md5verify cmd could easily be added, but would not be recommended to use because of known weaknesses with MD5 digests
bmwiedemann
force-pushed
the
digestverify
branch
from
af262d1
to
07f50e4
Compare
because we are only ever interested in the hex string of the digest value
|
ping |
|
There is weaknesses in sha1 to; https://shattered.io Go for sha256 at least. |
|
It needs a substantial cleanup before being mergeable. Also, rather than argue over which digest algorithm commands should exist, we should be able to use whichever digests are compiled in (which is controlled by config/crypto.h); this will require either a command syntax such as "digest sha256 |
|
I just noticed that this is similar to #34 but I cannot follow up on either. So, if someone wants to pick this up, I'd welcome it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to get a trusted image with known digest value
that is embedded in the ipxe script
example usage:
kernel http://boot.ipxe.org/memtest.0
sha1verify memtest.0 5d78d4c7e97c99bca3d3dff602b84dde5b70c5bf
boot
an md5verify cmd could easily be added,
but would not be recommended to use
because of known weaknesses with MD5 digests