[util] Fix a potential problem in ROM.pm. #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbankov-vmware
force-pushed
the
topic/dbankov/rom-utils-fix
branch
from
7ed8519
to
31fbb7c
Compare
dbankov-vmware
changed the title
|
The Logical Defined-Or operator ( // ) was introduced to Perl 5.10 released on December 18th, 2007. I think it's a long enough time for it to be routinely used. |
|
The proposed patch mentions a _runtime_ error.
Cheers
Geert Stappers
Through E-mail, not sure if it ends up at github ...
|
I'm sorry this is not phrased correctly (I'll edit the description). The problem is observed during the script execution which happens as part of the build process. The result is a broken (make all) build on a build machine with perl 5.8.8. I don't insist on merging this PR just thought I'd propose it. |
This change replaces "my $file_offset = shift // 0x0;" (which results in a build failure in some environments) with "my $file_offset = scalar @_ ? shift : 0x0;" where the intention is 0x0 to be the default value used if the optional file_offset parameter is not provided.
dbankov-vmware
force-pushed
the
topic/dbankov/rom-utils-fix
branch
from
31fbb7c
to
bd5df7c
Compare
This comment was marked as abuse.
This comment was marked as abuse.
|
Thanks for looking at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces "my $file_offset = shift // 0x0;" (which results in a
build failure in some environments) with "my $file_offset = scalar @_ ? shift : 0x0;" where
the intention is 0x0 to be the default value used if the optional
file_offset parameter is not provided.