Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using post-link script in conda recipe #1311

Open
eferreira opened this issue Jun 14, 2018 · 2 comments
Open

Stop using post-link script in conda recipe #1311

eferreira opened this issue Jun 14, 2018 · 2 comments

Comments

@eferreira
Copy link

Apologies if this has been discussed before. I noticed that the conda recipe for this project does quite a bit in the post-link phase. Namely it runs jupyter-contrib-nbextension install, which has the effect of copying a lot of files around and editing some other files in place.

I just wanted to discuss the feasibility of moving all this into the build phase of the conda recipe, and publishing the result as a conda package without any post-link script. For the files that are edited in place, this seems relevant: jupyter/notebook#3116. It should be possible to avoid needing to edit any existing files, and just create new files in *.d/ directories instead.

Has anyone tried this already? Is there some major reason that I'm missing why this wouldn't work?

@jcb91
Copy link
Member

jcb91 commented Jun 14, 2018

Hi! No, no reason not to do it that I know of. I just I haven't had time to do anything to this repo for a while, so haven't looked into the new .d stuff. If you fancy dropping a pr, feel free :)

@kiwi0fruit
Copy link

Seee the last part: https://conda.io/projects/conda-build/en/latest/source/link-scripts.html

If the last one is violated (Depend only on simple system tools such as rm, cp, mv and ln.) then there would definitely be pre-link and post-link.sh errors during environmet creation/removing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants