flush after sending replies #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to ensure that the reply is actually sent before we handle the next request
|
Yay! That does fix the problem in the nb that was reproducing it. Thank you so much, @minrk! |
|
Are there any obstacles to merging this fix, @minrk? |
|
Any reason why this fix doesn't get merged, anybody? |
|
Hi, could someone merge this fix? |
|
LGTM |
|
Released to PyPI as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to ensure that the reply is actually sent before we handle the next request
closes #389
closes jupyter/notebook#2748
closes jupyter/notebook#4334
cc @stas00