Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: method flush() in iostream.py #463

Merged
merged 1 commit into from Dec 5, 2019
Merged

fix: method flush() in iostream.py #463

merged 1 commit into from Dec 5, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 3, 2019

When shutting down, the flush() method does not work correctly.

if self.pub_thread.thread.is_alive():
AttributeError: 'NoneType' object has no attribute 'thread'

[C 02:15:42.905 NotebookApp] Shutdown confirmed
[I 02:15:42.908 NotebookApp] Shutting down 2 kernels
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
File "/Users/valentin/brew/Cellar/python/3.7.5/Frameworks/Python.framework/Versions/3.7/lib/python3.7/logging/init.py", line 2033, in shutdown
h.flush()
File "/Users/valentin/.pyenv3/tensorflow/lib/python3.7/site-packages/absl/logging/init.py", line 891, in flush
self._current_handler.flush()
File "/Users/valentin/.pyenv3/tensorflow/lib/python3.7/site-packages/absl/logging/init.py", line 785, in flush
self.stream.flush()
File "/Users/valentin/.pyenv3/tensorflow/lib/python3.7/site-packages/ipykernel/iostream.py", line 341, in flush
if self.pub_thread.thread.is_alive():
AttributeError: 'NoneType' object has no attribute 'thread'
[I 02:15:43.531 NotebookApp] Kernel shutdown: d514bdbe-8879-44de-b4d9-01d160a5be94
[I 02:15:43.534 NotebookApp] Kernel shutdown: 7579b41f-76f6-4a7c-8dd8-c35bf90dbbba

@minrk minrk merged commit f86623b into ipython:master Dec 5, 2019
@minrk
Copy link
Member

minrk commented Dec 5, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants