Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Don't enter None eventloop #464

Merged
merged 2 commits into from
Mar 17, 2020
Merged

PR: Don't enter None eventloop #464

merged 2 commits into from
Mar 17, 2020

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Dec 4, 2019

I had a case where eventloop was None here (I couldn't find a reproducible example).
It doesn't make sense to enter the eventloop if there is no eventloop.

@impact27 impact27 changed the title Fix None eventloop PR: Fix None eventloop Dec 4, 2019
@impact27 impact27 changed the title PR: Fix None eventloop PR: Don't enter None eventloop Dec 4, 2019
@Carreau Carreau added this to the 5.2 milestone Feb 2, 2020
blink1073
blink1073 approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit f734ec9 into ipython:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@impact27 @blink1073 @Carreau