Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pdb on Windows interruptible #490

Merged
merged 8 commits into from
May 27, 2020

Conversation

itamarst
Copy link
Contributor

@itamarst itamarst commented Mar 2, 2020

This is the final fix for ipython/ipython#10516

Without the fix:

  1. The test fails.
  2. If you open Jupyter on Windows, run pdb.set_trace(), and then in same cell run some other code while pdb is still waiting for input, the interrupt button won't work.

With the fix:

  1. The test passes.
  2. pdb.set_trace() is finally interruptible on Windows, even in the scenario described above.

@itamarst itamarst marked this pull request as ready for review May 26, 2020 15:28
@itamarst
Copy link
Contributor Author

@blink1073 one final PR and pdb is interruptible on Windows!

@itamarst itamarst changed the title Replace pdb with the IPython custom debugger Make pdb on Windows interruptible May 27, 2020
@blink1073 blink1073 added this to the 5.4 milestone May 27, 2020
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Because this changes a public API I marked it for the next minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants