Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use bare except #721

Merged
merged 1 commit into from Jul 12, 2021
Merged

Do not use bare except #721

merged 1 commit into from Jul 12, 2021

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Jul 12, 2021

Part of the #717 PR-group.

Bare excepts replaced by except Exception/BaseException.

Here I'd like to have a second opinion in each case whether Exception/BaseException is the right thing.

@Carreau
Do not use bare except
c7b593f 
Part of the ipython#717 PR-group.

Bare excepts replaced by except Exception/BaseException
blink1073
blink1073 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added this to the 6.0.x milestone Jul 12, 2021
@blink1073 blink1073 merged commit 4a4ee44 into ipython:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
6.0.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Carreau @blink1073