Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump importlib-metadata limit for python<3.8 #738

Merged
merged 2 commits into from Aug 12, 2021

Conversation

ltalirz
Copy link
Contributor

@ltalirz ltalirz commented Aug 12, 2021

Related to #645

The importlib-metadata version was limited to <4 due to a corresponding restriction in the argcomplete package.
The latest argcomplete patch release has bumped the limit to <5.

Note: ipykernel does not depend on argcomplete directly.
I could also add an explicit dependency argcomplete>=1.12.3 to select latest version if that is preferred

…rsion was limited to <4 due to a corresponding restriction in the argcomplete package. The latest argcomplete patch release has bumped the limit to <5.
@blink1073
Copy link
Member

I could also add an explicit dependency argcomplete>=1.12.3 to select latest version if that is preferred

👍🏼

@blink1073 blink1073 added this to the 6.1 milestone Aug 12, 2021
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 1911e66 into ipython:master Aug 12, 2021
@ltalirz
Copy link
Contributor Author

ltalirz commented Aug 12, 2021

Thanks for the quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants