Add support for the debug modules request #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanMabille
requested changes
Dec 1, 2021
echarles
force-pushed
the
feat/debugModulesRequest
branch
from
872ab23
to
57a0fce
Compare
echarles
force-pushed
the
feat/debugModulesRequest
branch
from
95711b8
to
28a9b0f
Compare
|
Current comments have been addressed. This is ready for review/merge. |
|
LGTM |
|
Thx @JohanMabille and @Carreau for the review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for the Modules request https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Modules as discussed on jupyterlab/jupyterlab#11566 (comment)