Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle all threads stopped correctly #849

Merged
merged 6 commits into from
Feb 1, 2022

Conversation

JohanMabille
Copy link
Contributor

This PR fix the issues of the stored stopped threads when receiving a stopped event with allThreadsStopped set to True

@blink1073
Copy link
Member

It looks like the Ubuntu failures are relevant

@JohanMabille
Copy link
Contributor Author

JohanMabille commented Feb 1, 2022

Indeed, a test was missing a "wait on stopped event" before sending the next debug request.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ipykernel/control.py Outdated Show resolved Hide resolved
ipykernel/heartbeat.py Outdated Show resolved Hide resolved
ipykernel/heartbeat.py Outdated Show resolved Hide resolved
ipykernel/iostream.py Outdated Show resolved Hide resolved
ipykernel/iostream.py Outdated Show resolved Hide resolved
@blink1073 blink1073 merged commit 8383787 into ipython:main Feb 1, 2022
@JohanMabille JohanMabille deleted the multistopped branch February 2, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants