Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include method signatures in experimental completion results #895

Merged
merged 1 commit into from Mar 30, 2022
Merged

Include method signatures in experimental completion results #895

merged 1 commit into from Mar 30, 2022

Conversation

MrBago
Copy link

@MrBago MrBago commented Mar 30, 2022 •
edited

Method signatures are trivially available for autocomplete requests, I'd like to make them available via the jupyter complete_request.

@MrBago MrBago changed the title Include method signature in Include method signatures in experimental completion results Mar 30, 2022
blink1073
blink1073 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073 blink1073 merged commit 7717f2c into ipython:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MrBago @blink1073