Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not try to send on iostream if closed #899

Merged
merged 1 commit into from Mar 31, 2022
Merged

Do not try to send on iostream if closed #899

merged 1 commit into from Mar 31, 2022

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 added the bug label Mar 31, 2022
@blink1073 blink1073 mentioned this pull request Mar 31, 2022
Merged
5 tasks
@blink1073 blink1073 changed the title Do not try to send if on iostream closed Do not try to send on iostream if closed Mar 31, 2022
@bollwyvl
Copy link
Contributor

should we hold on this, downstream?

@blink1073
Copy link
Member Author

Either that or kick CI and hope

@blink1073
Copy link
Member Author

I'm afk for the next hour

@blink1073 blink1073 merged commit 3c6752a into ipython:main Mar 31, 2022
@blink1073 blink1073 deleted the fix-io-stream branch March 31, 2022 14:46
@blink1073
Copy link
Member Author

Since conda-forge/ipykernel-feedstock#119 passed, I don't see a need to rush this out.

@japm48 japm48 mentioned this pull request Jun 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blink1073 @bollwyvl