Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use packaging instead of pkg_resources to parse versions #900

Merged
merged 1 commit into from Apr 1, 2022

Conversation

minrk
Copy link
Member

@minrk minrk commented Apr 1, 2022

Pinning setuptools as a runtime dependency is often a problem, and setting a minimum of extremely recent setuptools 60 is causing conflicts with e.g. pandas which pins setuptools<60 (this is making an unsolvable conda environment for me right now).

migration advice suggests using the lighter packaging package, and I don't see a reason to use a version pin.

The pkg_resources function is also available for at least 30 versions (setuptools 30), so the >=60 doesn't seem to have been the right number to use.

Recommend a patch release with the fix, since the dependency in 6.11 is causing installation problems.

requiring setuptools 60 causes compatibility problems with e.g. pandas
@bollwyvl
Copy link
Contributor

bollwyvl commented Apr 1, 2022

Ick:

         File "/tmp/pip-download-q4sqesd9/ipyparallel_89b290df93ac4e98934f08ef9634b493/setupbase.py", line 37, in <module>
          from setuptools.config import StaticModule
      ImportError: cannot import name 'StaticModule' from 'setuptools.config' (/tmp/pip-build-env-tf4je9_5/overlay/lib/python3.9/site-packages/setuptools/config/__init__.py)
      [end of output]

@bollwyvl
Copy link
Contributor

bollwyvl commented Apr 1, 2022

ugh, it's the homebrew get_version in setupbase (which has propagated to jupyter_packaging)... i don't think that's can be blocker here, though, if other stuff is broken downstream...

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit e8ffc9e into ipython:main Apr 1, 2022
@minrk minrk deleted the packaging branch April 1, 2022 18:00
@minrk
Copy link
Member Author

minrk commented Apr 1, 2022

I fixed the setuptools 61 issue in ipyparallel in ipython/ipyparallel#680 , just need to make a release.

markotoplak added a commit to markotoplak/orange3-feedstock that referenced this pull request Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants