Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how to release packages whose source contains ipynb files #8

Closed
yuvipanda opened this issue Nov 6, 2016 · 5 comments
Closed

Comments

@yuvipanda
Copy link
Collaborator

Ideally these will not require the ipynb package at all at runtime. We could do some amount of pre-processing to make sure we ship .py files rather than .ipynb files, and dependency on IPython itself will depend on #6.

This totally requires us to have a solid documented understanding of how relative imports work (see #4)

@yuvipanda
Copy link
Collaborator Author

If we really get this going we could maybe go all meta and write ipynb in ipynb :D

@Carreau
Copy link
Member

Carreau commented Nov 8, 2016

So there are various ways to do that:

  1. have the "setup.py" to build a py-version of all the notebooks.
    I'm going to assume that users won't modify an installed package :-)
    Then it will require ipynb as install time. Though "show source" might be wrong-ish.

  2. Require ipynb, an one .py files that "register" this particular packages as a prefix for which the import hook should work.

@yuvipanda
Copy link
Collaborator Author

Yeah, I prefer 1 far more than 2. I suppose we just need a way to do pre-processing of files?

@Carreau
Copy link
Member

Carreau commented Nov 8, 2016

Yeah, I prefer 1 far more than 2. I suppose we just need a way to do pre-processing of files?

Should not be too hard.

@yuvipanda
Copy link
Collaborator Author

This is done now, we have a setup_packages() implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants