Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBSControllerLauncher broken in 7.1.0 #617

Closed
lukas-koschmieder opened this issue Oct 27, 2021 · 1 comment
Closed

PBSControllerLauncher broken in 7.1.0 #617

lukas-koschmieder opened this issue Oct 27, 2021 · 1 comment

Comments

@lukas-koschmieder
Copy link

PBSControllerLauncher appears to be broken in 7.1.0 because the attribute/method poll is not implemented.

ipyparallel raises an exception AttributeError: 'PBSControllerLauncher' object has no attribute 'poll' at

status = self.poll()

You can use the following code to replicate the error.

import ipyparallel as ipp
rc=ipp.Cluster(
    n=4, 
    controller_ip='*', 
    controller_launcher_class='ipyparallel.cluster.launcher.PBSControllerLauncher', 
    engine_launcher_class='ipyparallel.cluster.launcher.PBSEngineSetLauncher',
    profile='pbs'
).start_and_connect_sync()

Stdout:

Job submitted with job id: '23736'
Starting 4 engines with <class 'ipyparallel.cluster.launcher.PBSEngineSetLauncher'>
Job submitted with job id: '23737'
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)

(...)

/opt/conda/envs/ipp/lib/python3.9/site-packages/ipyparallel/cluster/launcher.py in get_connection_info(self)
    342                 self.log.debug(f"Waiting for {paths}")
    343             await asyncio.sleep(0.1)
--> 344             status = self.poll()
    345             if inspect.isawaitable(status):
    346                 status = await status

AttributeError: 'PBSControllerLauncher' object has no attribute 'poll'
@minrk
Copy link
Member

minrk commented Oct 27, 2021

Thanks! This is fixed by #606

planning to make another release this week

@minrk minrk closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants