Drop consecutive duplicates when refilling readline history #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aside: the equivalent thing also needs fixing in the Qt console. I'll see if I can track down the relevant code and add it to this PR. |
|
Found the relevant bit for the Qt console too. |
| @@ -1804,6 +1806,7 @@ class InteractiveShell(SingletonConfigurable, Magic): | |||
| for line in cell.splitlines(): | |||
| self.readline.add_history(py3compat.unicode_to_str(line, | |||
| stdin_encoding)) | |||
| last_cell = cell.rstrip() | |||
There was a problem hiding this comment.
You can eliminate these three strip()/rstrip() calls by using a single stripped = cell.rstrip(), and if stripped and stripped != last_cell:, yes?
|
Looks great, works great, and fixes a really annoying little regression. Great job, as always. Totally deserving of the issue #1000 award!! :) Will merge now, thanks a lot. |
fperez
added a commit
that referenced
this pull request
Nov 20, 2011
Drop consecutive duplicates when refilling history, both in the terminal (via readline) and in the qt console.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Drop consecutive duplicates when refilling history, both in the terminal (via readline) and in the qt console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd better fix that bug if I'm getting a tshirt for it.
This operates at the cell level, even if the user disables multiline_history in the terminal, so you can define a multiline function twice, and only have to flip through it once after you start a new session.
There's an added bonus fix for setting the next input at the terminal on Python 3.