Use repr() to make quoted strings #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that %r will do the repr() for you. |
|
Good point. Done. |
fperez
added a commit
that referenced
this pull request
Nov 20, 2011
Use repr() to make quoted strings. This simplifies our quoting code by letting us rely on built-in capabilities of the language.
|
Thanks, looks great (and to @rkern for the review!). Merged. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Use repr() to make quoted strings. This simplifies our quoting code by letting us rely on built-in capabilities of the language.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should at least begin to fix #1009, by correctly escaping strings with
\Uor\uin them.This only broke a few tests because
reprdefaults to 'single quotes', whereas our implementation defaulted to "double quotes". I've fixed those.Bonus fix: a couple of config tests were failing on Python 3.