json/jsonapi cleanup #1040
Closed
json/jsonapi cleanup #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* never use zmq.utils.jsonapi when talking to files * catch decimal.Decimal returned by jsonlib in the parallel scheduler * remove IPython.zmq.jsonapi shim
|
This looks good, verified that the test suite now completes with jsonlib installed. I'd much rather take this approach than having in-house little hacks, so I'm merging it now (rebased to avoid recursive merge for just a single commit). |
|
Pushed as 3892cf3, closing. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #1037 for details.