Skip to content
This repository

Notebook tab completion broken in Firefox #1068

Closed
jenshnielsen opened this Issue November 30, 2011 · 4 comments

2 participants

Jens H Nielsen Matthias Bussonnier
Jens H Nielsen

After the merge of the notebook-as-you-type-completer the tab completion
using firefox is broken. When hitting enter to select a completion it is inserted twice
and the completion box is not closed. If you then try to complete something new
it only shows the completion from the previous attempt and you might get several
completion boxes on top of each other.
I also got it into a state once where after trying to complete plt.something
I could not delete the .

In chrome 16 it works fine and is a huge usability gain for the notebook.
Using the latest git version d7d57eb on Ubuntu 11.10

Matthias Bussonnier
Collaborator

Right, I (kind of) can reproduce it... could you try test-fix-ff-completeron https://github.com/Carreau/ipython.git and tell me if it works.

actually, it looked like you weren't able to delete . but it might have been because of 8 to 10 invisible caracters with no length after...

Javascript event keypress and keydown totally differs between browser and it's a mess to handle.
I'll try to came with some test case to run on different browser to test the completer.

Matthias Bussonnier
Collaborator

To anyone reading this...
some test case for the completer in the notebook, with the --pylab flag.

#test direct one completion
plt.an<tab>  --> plt.annotate
====
#test filter,tab, only one completion
plt.a<tab>n<tab>  --> plt.annotate
===
# test partial common beggining
plt.a<tab>nn<backspace><backspace>u<tab> -> complter to aut
........................................<tab><tab><tab>
# test dismmised if user erase
.......................................................<backspace><backspace<backspace> -> complter cancelled
===
plt.s<tab>c -> completer 3 choices
...........u -> dismissed whith what user have typed. ( plt.scu)

Feel free to complete and test on other browser.

Matthias Bussonnier
Collaborator

@fperez
PR #1039 is buggy on firefox, could you try test-fix-ff-completeron https://github.com/Carreau/ipython.git see if it fixes things ?

Jens H Nielsen

From a quick test that seems to fix it and it still works in Chrome. Thanks a lot.

Jens H Nielsen jenshnielsen closed this November 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.