New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qtconsole : allow copy with shortcut in pager #1091
Conversation
'user_expression' does not exist with --pure, be more carefull..
I also added a little fix that avoid some error message when trying qtconsole with Actually I suspect that some of the gui menu of qtconsole might be broken with |
note that we might want to add a warning in the docstring of Which way you think is the best ? |
@Carreau - you are right, there are probably quite a few things broken in pure mode. I wish we would remove it, because nobody ever tests it, and there are huge amounts of duplicate code that typically are not updated in tandem with every change. |
if text: | ||
lines = map(transform_ipy_prompt, text.splitlines()) | ||
text = '\n'.join(lines) | ||
QtGui.QApplication.clipboard().setText(text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make 'transform_prompt` a widget trait (should be transform_classic_prompt in FrontendWidget, and transform_ipy_prompt in IPythonWidget), then we shouldn't have to override copy() in IPythonWidget at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite comfortable with trait
, I can give a shot, bu you'll probably be done before I read enough to do it the right way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it can just be a class attribute. The traitness is unimportant.
When doing |
hum... I didn't thought of vsplit. I'll take a look. |
check which of the two widget have focus to know from which to copy
@minrk, |
closes ipython#1088 closes ipython#1091
closes #1088