Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo, should fix #1095 #1097

Closed
wants to merge 1 commit into from
Closed

typo, should fix #1095 #1097

wants to merge 1 commit into from

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Dec 4, 2011

cancell -> cancel

was rising exception in JS console and not closing tooltip.

@minrk
Copy link
Member

minrk commented Dec 4, 2011

Thanks, good catch. I had to clean up the javascript a bit, because some of it was inappropriate.

You should never actually call the prototype functions, and never pass an object to its own methods, and (almost) never need to pass any of its attributes to its own methods.

That's like calling a method of a class rather than the method of an instance:

Cell.prototype.method(that)

should just be:

that.method()

It's like doing:

cell = Cell()
Class.method(cell)

instead of just:

cell.method()

See fbed9d1 for the relevant changes.

@minrk minrk closed this Dec 4, 2011
@Carreau
Copy link
Member Author

Carreau commented Dec 5, 2011

indead, that seem obvious in OO programming, i'm just not used to JS....Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants