rename MPIExecLaunchers to MPILaunchers #1137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't tested this, but I think this is semantically a good change. |
|
The code should behave exactly the same for users who replace 'MPIExec' with 'MPI', since all I did was rename the classes. The only new code is the deprecated versions of the old names, which have worked fine in my tests so far, using command-line args and config files with the old names. |
MPIExec is unwieldy, and unnecessarily specific when they can be
configured to use mpirun, aprun, etc.
This means you can now start an MPI cluster with just:
$> ipcluster start --engines=MPI
old names still work, logging deprecation warnings.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
MPIExec is unwieldy, and unnecessarily specific when they can be
configured to use mpirun, aprun, etc.
This means you can now start an MPI cluster with just:
$> ipcluster start --engines=MPI
old names still work, logging deprecation warnings.
closes ipython#1137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPIExec is unwieldy, and unnecessarily specific when they can be configured to use mpirun, aprun, etc.
This means you can now start an MPI cluster with just:
old names still work, logging deprecation warnings and pointing to the new names.