Add post_install script to create start menu entries in Python 3 #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this I understand and am super comfortable with, so I'll do a test in a VM, and merge if it works. |
|
Various few small fixes (print_statement, '3' suffix on files) are required to the script itself, but I've made them locally and this works just fine. I'll merge in a sec. |
|
Thanks, Min. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Start Menu items are now installed with bdist_wininst on Python 3. closes ipython#1143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1119, but I can't test it, because I don't have a Windows machine handy, and Python in Wine seems to be having problems.
Can someone with a Windows machine test it? You'll need Python 3.2 installed. With this branch checked out, run
C:\python32\python.exe setup.py bdist_wininst. This will produce a .exe installer - run that, and see if it completes without errors and creates start menu entries for IPython on Python 3.