Pager tearing bug #1153
Merged
Pager tearing bug #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prabhuramachandran, please simply rebase your branch onto master, so that we don't have criss-crossing of the history. Basically your PR should only show your own commits, and not the master merge. Let us know if you need a hand with the rebase details and we'll be happy to help. |
On Mac OS X, scrolling the pager when it is split vertically causes the help text to tear (i.e. the help text is unreadable). This hack attempts to make it a little better although the solution may not be optimal at all.
|
@fperez, sorry about that, I've rebased and hope this is OK. Do let me know if I've messed anything up. Thanks. |
|
I've also tested on ubuntu 11.10 and it works OK here. Since we had already tested the exact same logic yesterday on OSX, I'll go ahead and merge now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to #1150. I've merged these changes with master as well and tested this on Linux and Windows XP 64 bit and it works fine. The tearing bug isn't completely gone but until we find a cleaner solution this at least makes the pager functional when used in the vsplit mode.