minor post-execute fixes (#1154) #1155

minrk · 2011-12-14T21:21:50Z

Two changes:

Don't unregister failing post-exec callbacks automatically. Instead, print a message regarding the failure, pointing to new disable_failing_post_execute trait for skipping failing callbacks.
- When this flag is False (the default), failing callbacks will continue to be called.
- When True, behavior is unchanged from previous, where callbacks are only allowed to fail once.
protect flush_figures() post-exec function from user error. Invalid matplotlib data may raise inside print_figure(). flush_figures() is a post-exec function, so user errors should not raise. Instead, call get_ipython().showtraceback() if called from IPython, raising as before otherwise.

Instead, print a message regarding the failure, pointing to new `disable_failing_post_execute` trait for skipping failing callbacks. When this flag is False (the default), failing callbacks will continue to be called. When True, behavior is unchanged from previous, where callbacks are only allowed to fail once.

Invalid matplotlib data may raise inside print_figure. flush_figures() is a post-exec function, so user errors should not raise. Instead, call get_ipython().showtraceback() if called from IPython, raising as before otherwise.

fperez · 2011-12-15T00:29:09Z

Reviewed together at Berkeley, @minrk is making one tiny fix and then we'll merge.

Be less aggressive in de-registering failing post-execute functions so that normal errors don't disable them permanently. Two changes: 1. Don't unregister failing post-exec callbacks automatically. Instead, print a message regarding the failure, pointing to new `disable_failing_post_execute` trait for skipping failing callbacks. - When this flag is False (the default), failing callbacks will continue to be called. - When True, behavior is unchanged from previous, where callbacks are only allowed to fail once. 2. protect `flush_figures()` post-exec function from user error. Invalid matplotlib data may raise inside `print_figure()`. flush_figures() is a post-exec function, so user errors should not raise. Instead, call `get_ipython().showtraceback()` if called from IPython, raising as before otherwise. closes #1154

Be less aggressive in de-registering failing post-execute functions so that normal errors don't disable them permanently. Two changes: 1. Don't unregister failing post-exec callbacks automatically. Instead, print a message regarding the failure, pointing to new `disable_failing_post_execute` trait for skipping failing callbacks. - When this flag is False (the default), failing callbacks will continue to be called. - When True, behavior is unchanged from previous, where callbacks are only allowed to fail once. 2. protect `flush_figures()` post-exec function from user error. Invalid matplotlib data may raise inside `print_figure()`. flush_figures() is a post-exec function, so user errors should not raise. Instead, call `get_ipython().showtraceback()` if called from IPython, raising as before otherwise. closes ipython#1154

minrk added 2 commits December 14, 2011 13:07

protect flush_figures post-exec function from user error

c98183c

Invalid matplotlib data may raise inside print_figure. flush_figures() is a post-exec function, so user errors should not raise. Instead, call get_ipython().showtraceback() if called from IPython, raising as before otherwise.

minrk mentioned this pull request Dec 14, 2011

We should be less aggressive in de-registering post-execution functions #1154

Closed

don't catch potential NameErrors in showtraceback()

b319385

fperez merged commit 2c683b7 into ipython:master Dec 15, 2011

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

minor post-execute fixes (#1154) #1155

minor post-execute fixes (#1154) #1155

minrk commented Dec 14, 2011

fperez commented Dec 15, 2011

minor post-execute fixes (#1154) #1155

minor post-execute fixes (#1154) #1155

Conversation

minrk commented Dec 14, 2011

fperez commented Dec 15, 2011