Allow %loadpy to load remote URLs that don't end in .py #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| and not arg_s.endswith('.py'): | ||
| # Local files must be .py; for remote URLs it's possible that the | ||
| # fetch URL doesn't have a .py in it (many servers have an opaque | ||
| # URL, such as scipy-central.org). | ||
| raise ValueError('%%load only works with .py files: %s' % arg_s) | ||
| if arg_s.startswith('http'): |
There was a problem hiding this comment.
Don't forget to change this one as well (same issue with local files like 'httpx.py')
Use extra local variables that are easier to read than double-negatives.
|
Reviewed by @takluyver and @minrk on IRC in addition to what's here, merging now. |
fperez
added a commit
that referenced
this pull request
Dec 16, 2011
Allow %loadpy to load remote URLs that don't end in .py. Also strip encoding declarations from loaded files, which are invalid for interactively defined strings.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Allow %loadpy to load remote URLs that don't end in .py. Also strip encoding declarations from loaded files, which are invalid for interactively defined strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will also fix same encoding bug we found for notebooks next.