Add --script flag as shorthand for notebook save_script option. #1168
+56
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,10 +47,12 @@ class NotebookManager(LoggingConfigurable): | |||
| """) | |||
|
|
|||
| save_script = Bool(False, config=True, | |||
| help="""Also save notebooks as a Python script. | |||
| help="""Automaticall create a Python script when saving the notebook. | |||
There was a problem hiding this comment.
Automatically - it's missing the y
| # the flags that are specific to the frontend | ||
| # these must be scrubbed before being passed to the kernel, | ||
| # or it will raise an error on unrecognized flags | ||
| notebook_flags = ['no-browser', 'no-mathjax', 'read-only'] | ||
| notebook_flags = ['no-browser', 'no-mathjax', 'read-only', 'script'] |
There was a problem hiding this comment.
need to include 'no-script' in notebook_flags, so it won't be relayed to kernel
|
Typically we have defined flags in the same file as the application that uses them, but I don't actually see anything wrong with doing it this way. |
|
OK, I'll move it over for consistency's sake. Not having done it before, I did what seemed most obvious immediately, but I think it's better to keep a consistent pattern. |
|
Pushed, let me know how it looks and we'll merge when ready. Thanks for the review! |
|
thanks, looks good. Go ahead and merge. |
|
Great, thanks. Merging now. |
fperez
added a commit
that referenced
this pull request
Dec 18, 2011
Add --script/--no-script flags as shorthands for the NotebookManager.save_script option.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Add --script/--no-script flags as shorthands for the NotebookManager.save_script option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also expand the section of the docs dealing with notebook imports.