core.completer: Clean up excessive and unused code. #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `mark_dirs` is only called from one location and it is more simply expressed as a one-liner using the ternary operator. - `single_dir_expand` is not called from anywhere in IPython.
|
This looks clean and sensible, thanks! |
minrk
added a commit
that referenced
this pull request
Dec 27, 2011
* remove mark_dirs, which can be expressed as list comprehension. * remove single_dir_expand, which is no longer used anywhere.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
* remove mark_dirs, which can be expressed as list comprehension. * remove single_dir_expand, which is no longer used anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mark_dirsis only called from one location and it is more simplyexpressed as a one-liner using the ternary operator.
single_dir_expandis not called from anywhere in IPython.